experimental patch for viewport module

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

experimental patch for viewport module

donbright
Dear OpenSCAD

Here is an experimental patch to add starting_viewport() and
animation_viewport() commands to Openscad

https://github.com/openscad/openscad/pull/16/files

Here is prototype documentation

http://en.wikibooks.org/wiki/User:Dbright/Viewport

Thanks
-DB

Reply | Threaded
Open this post in threaded view
|

Re: experimental patch for viewport module

Giles Bathgate-2
Don,

This feature has been suggested before, so its good to see that you
have done some work on working out how this might be implemented.

I am not sure that having it as a module is immediately obvious as:

1) Modules usually operate on nodes that are passed to them only.
2) I assume this works globally so you call it once then all
subsequent modules are effected?
3) Perhaps special variables would be a more appropriate way to
control this, e.g.

$viewport_location=[a,b,c];
$viewport_distance=a;

etc..

As was discussed before.

Regards

Giles.

On 10 July 2011 16:38, Don Bright <[hidden email]> wrote:

> Dear OpenSCAD
>
> Here is an experimental patch to add starting_viewport() and
> animation_viewport() commands to Openscad
>
> https://github.com/openscad/openscad/pull/16/files
>
> Here is prototype documentation
>
> http://en.wikibooks.org/wiki/User:Dbright/Viewport
>
> Thanks
> -DB
> _______________________________________________
> OpenSCAD mailing list
> [hidden email]
> http://rocklinux.net/mailman/listinfo/openscad
>

Reply | Threaded
Open this post in threaded view
|

Re: experimental patch for viewport module

donbright
Thanks, I will investigate.


On Sun, Jul 10, 2011 at 10:45 AM, Giles Bathgate
<[hidden email]> wrote:

> Don,
>
> This feature has been suggested before, so its good to see that you
> have done some work on working out how this might be implemented.
>
> I am not sure that having it as a module is immediately obvious as:
>
> 1) Modules usually operate on nodes that are passed to them only.
> 2) I assume this works globally so you call it once then all
> subsequent modules are effected?
> 3) Perhaps special variables would be a more appropriate way to
> control this, e.g.
>
> $viewport_location=[a,b,c];
> $viewport_distance=a;
>
> etc..
>
> As was discussed before.
>
> Regards
>
> Giles.
>
> On 10 July 2011 16:38, Don Bright <[hidden email]> wrote:
>> Dear OpenSCAD
>>
>> Here is an experimental patch to add starting_viewport() and
>> animation_viewport() commands to Openscad
>>
>> https://github.com/openscad/openscad/pull/16/files
>>
>> Here is prototype documentation
>>
>> http://en.wikibooks.org/wiki/User:Dbright/Viewport
>>
>> Thanks
>> -DB
>> _______________________________________________
>> OpenSCAD mailing list
>> [hidden email]
>> http://rocklinux.net/mailman/listinfo/openscad
>>
> _______________________________________________
> OpenSCAD mailing list
> [hidden email]
> http://rocklinux.net/mailman/listinfo/openscad
>