What is supposed to trigger the mouse click stack trace?

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

What is supposed to trigger the mouse click stack trace?

nophead
I keep getting a popup stack trace when I am panning and rotating the preview. Since I have the editor hidden it makes no sense as it changes the current file with no way to get back to the file I am viewing without enabling the editor.



_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
tp3
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

tp3
I can pan and rotate just fine without any popup menu. Only
actual clicks, so mouse button press + mouse button release
without any movement triggers the popup.

That said, it sounds reasonable to disable with editor hidden
as done in other places already.

ciao,
  Torsten.

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
It is far too easy accidentally trigger in my opinion. Should be something like shift-click. I keep losing my view and have to enable the editor, close the new tab and hit F5 and wait for it to render again and then close the editor tab to get back to where I started.

On Mon, 7 Dec 2020 at 14:49, Torsten Paul <[hidden email]> wrote:
I can pan and rotate just fine without any popup menu. Only
actual clicks, so mouse button press + mouse button release
without any movement triggers the popup.

That said, it sounds reasonable to disable with editor hidden
as done in other places already.

ciao,
  Torsten.

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
Also double left click is centre the view but now it also brings up the stack trace, which is enormous.

On Mon, 7 Dec 2020 at 14:53, nop head <[hidden email]> wrote:
It is far too easy accidentally trigger in my opinion. Should be something like shift-click. I keep losing my view and have to enable the editor, close the new tab and hit F5 and wait for it to render again and then close the editor tab to get back to where I started.

On Mon, 7 Dec 2020 at 14:49, Torsten Paul <[hidden email]> wrote:
I can pan and rotate just fine without any popup menu. Only
actual clicks, so mouse button press + mouse button release
without any movement triggers the popup.

That said, it sounds reasonable to disable with editor hidden
as done in other places already.

ciao,
  Torsten.

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

jotweh
Center the view was broken before the click thingy came into play, but I
am working on a fix combining both
It is a little bit tricky when the render time is longer than the double
click time interval, but at least they can both use the same object
selection logic.

If you do not click on an item when the list pops up, but anywhere else
on screen the list goes away and no editor is changed.
I have been working with this for a few months now, and even in an
external editor it is nice to know, where a structure was defined.
We can disable that the editor can be focused if it is closed, but I
would not disable clicking.

I would rather extend the dbus or emacs integration to be able to react
to such an event!

@nop head: Out of curiosity, which external editor do you use?



_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
People reported that double click was broken but it still worked for me on Win7. It works half the time now as it sometimes brings up the stack menu and depending on where the menu is it sometimes gets the second click and opens a new editor and that clears the render screen, which may need a long F5 to get it back.

The editor I use is one I wrote myself about 20 years ago in MFC. I use it because it is also my source control system. It has every version of everything accessible with a couple of clicks and can also compare anything with anything else. All my files are stored in an XML database on GoogleDrive. Edits happen in the database and only appear on the local drive when I hit F7 to build a project. That is when OpenSCAD sees them and auto reloads. 

I only use Github to publish code, I don't use it for my day to day source control. It gets a bit awkward when people submit PRs to NopSCADlib!

On Mon, 7 Dec 2020 at 16:17, <[hidden email]> wrote:
Center the view was broken before the click thingy came into play, but I
am working on a fix combining both
It is a little bit tricky when the render time is longer than the double
click time interval, but at least they can both use the same object
selection logic.

If you do not click on an item when the list pops up, but anywhere else
on screen the list goes away and no editor is changed.
I have been working with this for a few months now, and even in an
external editor it is nice to know, where a structure was defined.
We can disable that the editor can be focused if it is closed, but I
would not disable clicking.

I would rather extend the dbus or emacs integration to be able to react
to such an event!

@nop head: Out of curiosity, which external editor do you use?



_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
I just realised another reason I keep getting the pop up. If I want to zoom I click in the preview pane to give it focus and then use the mouse wheel. The single click brings up the menu.

On Mon, 7 Dec 2020 at 16:33, nop head <[hidden email]> wrote:
People reported that double click was broken but it still worked for me on Win7. It works half the time now as it sometimes brings up the stack menu and depending on where the menu is it sometimes gets the second click and opens a new editor and that clears the render screen, which may need a long F5 to get it back.

The editor I use is one I wrote myself about 20 years ago in MFC. I use it because it is also my source control system. It has every version of everything accessible with a couple of clicks and can also compare anything with anything else. All my files are stored in an XML database on GoogleDrive. Edits happen in the database and only appear on the local drive when I hit F7 to build a project. That is when OpenSCAD sees them and auto reloads. 

I only use Github to publish code, I don't use it for my day to day source control. It gets a bit awkward when people submit PRs to NopSCADlib!

On Mon, 7 Dec 2020 at 16:17, <[hidden email]> wrote:
Center the view was broken before the click thingy came into play, but I
am working on a fix combining both
It is a little bit tricky when the render time is longer than the double
click time interval, but at least they can both use the same object
selection logic.

If you do not click on an item when the list pops up, but anywhere else
on screen the list goes away and no editor is changed.
I have been working with this for a few months now, and even in an
external editor it is nice to know, where a structure was defined.
We can disable that the editor can be focused if it is closed, but I
would not disable clicking.

I would rather extend the dbus or emacs integration to be able to react
to such an event!

@nop head: Out of curiosity, which external editor do you use?



_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

jotweh
Yes indeed it does.

I hate to break your workflows - but at least on my linux installation
the click is not necessary.
Just mouseover the glview and I can scroll to zoom even without giving
the glview focus.

Should we add an option to disable the click completely?
Or can you get enough from this information generated by a click that it
warrants you getting used to it?

After learning and teaching I think this might help beginners understand
their and existing code much better. And It helps experienced users with
more complex models.


On 07/12/2020 18.44, nop head wrote:
> I just realised another reason I keep getting the pop up. If I want to
> zoom I click in the preview pane to give it focus and then use the
> mouse wheel. The single click brings up the menu.
>



_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
It also sometimes triggers when I am doing right click drag to pan when I release it.

I think it should be ctrl-click to prevent normal interaction with the window triggering it. Shift click is already used. I don't want to disable it completely as it could be useful.



On Tue, 8 Dec 2020 at 00:43, Johannes Walcher <[hidden email]> wrote:
Yes indeed it does.

I hate to break your workflows - but at least on my linux installation
the click is not necessary.
Just mouseover the glview and I can scroll to zoom even without giving
the glview focus.

Should we add an option to disable the click completely?
Or can you get enough from this information generated by a click that it
warrants you getting used to it?

After learning and teaching I think this might help beginners understand
their and existing code much better. And It helps experienced users with
more complex models.


On 07/12/2020 18.44, nop head wrote:
> I just realised another reason I keep getting the pop up. If I want to
> zoom I click in the preview pane to give it focus and then use the
> mouse wheel. The single click brings up the menu.
>



_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
Another problem is when it switches tabs all the customiser settings are lost. When it takes several minutes to get back to the previous state this is a breaking change.

On Tue, 8 Dec 2020 at 07:56, nop head <[hidden email]> wrote:
It also sometimes triggers when I am doing right click drag to pan when I release it.

I think it should be ctrl-click to prevent normal interaction with the window triggering it. Shift click is already used. I don't want to disable it completely as it could be useful.



On Tue, 8 Dec 2020 at 00:43, Johannes Walcher <[hidden email]> wrote:
Yes indeed it does.

I hate to break your workflows - but at least on my linux installation
the click is not necessary.
Just mouseover the glview and I can scroll to zoom even without giving
the glview focus.

Should we add an option to disable the click completely?
Or can you get enough from this information generated by a click that it
warrants you getting used to it?

After learning and teaching I think this might help beginners understand
their and existing code much better. And It helps experienced users with
more complex models.


On 07/12/2020 18.44, nop head wrote:
> I just realised another reason I keep getting the pop up. If I want to
> zoom I click in the preview pane to give it focus and then use the
> mouse wheel. The single click brings up the menu.
>



_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

MichaelAtOz
Administrator
nophead wrote
> Another problem is when it switches tabs all the customiser settings are
> lost. When it takes several minutes to get back to the previous state this
> is a breaking change.

Perhaps we need an Edit/Preferences/Advanced/UI/Enable-tabs setting?

I'm not sure of others, but I have not used tabs to any degree of
sophistication.



-----
OpenSCAD Admin - email* me if you need anything,  or if I've done something stupid...

* on the Forum, click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. Obviously inclusion of works of previous authors is not included in the above.

--
Sent from: http://forum.openscad.org/

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
OpenSCAD Admin - email* me if you need anything, or if I've done something stupid...
* on the Forum, click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain;
to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

JordanBrown
On 12/8/2020 2:30 AM, MichaelAtOz wrote:
Perhaps we need an Edit/Preferences/Advanced/UI/Enable-tabs setting?

I'm not sure of others, but I have not used tabs to any degree of sophistication.


I'm not a fan of tabs.  I have a perfectly good way of managing multiple documents, through windows, and it's a lot more flexible.  Tabs are fine for phone and tablet screens where the document pretty much has to take up the whole screen, but I have two 32" monitors and that's a whole different environment.

I don't know how they really interact with the click-to-find-associated-module question and so can't directly comment on the issue here, but the addition of tabs was a total negative for me; it made my window-centric habits be second-class citizens.  (Yes, you can still open new windows and open files in new windows, but not with Ctrl+N and the toolbar buttons; you have to crawl halfway down the menu with no shortcuts.)

I have a prototype that adds Edit/Preferences/Advanced/UI/Use Tabs; see
#3434 Restore multi-window operation as a first-class citizen
Torsten is (completely reasonably) concerned with the testing multiplication implied by a mode.

I'm holding out hope for the customizable-shortcuts project giving me the ability to restore Ctrl+N to open new windows.


_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

Dr Nicholas J Bailey
On Tuesday, 8 December 2020 13:28:23 GMT Jordan Brown wrote:
> I'm not a fan of tabs.  I have a perfectly good way of managing multiple
> documents, through windows, and it's a lot more flexible.  Tabs are fine
> for phone and tablet screens where the document pretty much has to take
> up the whole screen, but I have two 32" monitors and that's a whole
> different environment.

Yes!

Mind you, I have become quite partial to the tear-off tab of late, and the
kdenlive-style widget rearrangement, also allowing you to tear the frame out
to a separate window if you want to move it to a different monitor, for
example.




_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
> Perhaps we need an Edit/Preferences/Advanced/UI/Enable-tabs setting?

I think the proper solution is to fix all the bugs in the tabs feature.

Customiser settings need to be stored per tab.

Changing tabs should force a preview consistently. At the moment it seems to be when a new tab is opened but not when switching back to the old tabs.

On Tue, 8 Dec 2020 at 17:20, Dr Nicholas Bailey <[hidden email]> wrote:
On Tuesday, 8 December 2020 13:28:23 GMT Jordan Brown wrote:
> I'm not a fan of tabs.  I have a perfectly good way of managing multiple
> documents, through windows, and it's a lot more flexible.  Tabs are fine
> for phone and tablet screens where the document pretty much has to take
> up the whole screen, but I have two 32" monitors and that's a whole
> different environment.

Yes!

Mind you, I have become quite partial to the tear-off tab of late, and the
kdenlive-style widget rearrangement, also allowing you to tear the frame out
to a separate window if you want to move it to a different monitor, for
example.




_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

thehans

On Tue, Dec 8, 2020 at 12:10 PM nop head <[hidden email]> wrote:
> Perhaps we need an Edit/Preferences/Advanced/UI/Enable-tabs setting?

I think the proper solution is to fix all the bugs in the tabs feature.

Customiser settings need to be stored per tab.

Changing tabs should force a preview consistently. At the moment it seems to be when a new tab is opened but not when switching back to the old tabs.

It sounds like you have "Automatic Reload and Preview" enabled, so it previews when a new file/tab is opened.  That's only supposed to reload when the file on disk changes, right?  Not really much to do with tabs.

I prefer to leave Reload and Preview OFF, in which case changing tabs is perfectly consistent with opening a new one: neither forces a preview.

For example when editing a top level script that includes or uses a library file. I can Ctrl-click on the include line and it will conveniently open that file in a new tab.  In that case I don't see a reason to preview this file because it was written to be included, and so it has nothing to render itself.   I am fine with pressing F5 at the time of my choosing.

Anyways why do you care if you are using your own external editor?

Hans


_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

MichaelAtOz
Administrator
thehans wrote
> On Tue, Dec 8, 2020 at 12:10 PM nop head &lt;

> nop.head@

> &gt; wrote:
>
>> > Perhaps we need an Edit/Preferences/Advanced/UI/Enable-tabs setting?
>>
>> I think the proper solution is to fix all the bugs in the tabs feature.
>>
>> Customiser settings need to be stored per tab.
>>
>> Changing tabs should force a preview consistently. At the moment it seems
>> to be when a new tab is opened but not when switching back to the old
>> tabs.
>>
>
> It sounds like you have "Automatic Reload and Preview" enabled, so it
> previews when a new file/tab is opened.  That's only supposed to reload
> when the file on disk changes, right?  Not really much to do with tabs.

Seems Auto-reload-preview is triggered by just changing tabs, I don't think
it should do so.

Hmmm, that definitely happened,  
I had previously changed code in the first tab,
I can't remember which tab was live when I selected auto-reload-preview,
but when I was on the second tab I clicked back to tab 1,
it asked if I really wanted to reload, I said no.
But I haven't been able to reproduce it...
(and I'm 98.95% sure nothing modified the tab 1 file outside OpenSCAD)

Ahhh, customizer was viewable, with auto-preview selected.
I'm wondering if there is some unintended interaction.

I'll try some more combinations.


> Changing tabs should force a preview consistently. At the moment it seems
> to be when a new tab is opened but not when switching back to the old
> tabs.

See above, it did once on switching back.

When an existing file is opened in a new tab with auto-reload-preview,
preview is appropriate and consistent with past behaviour.

You, ie I, don't really want tabs to preview just switching to them,
I have one with a 30 minute minkowski preview.
If other tabs are libraries, you don't want them previewing.

Perhaps auto-reload-preview setting should be tab specific?
New tabs inherit the setting of the current tab??

ATM tabs are editor entities, not preview/render/customizer instances, ATM.
Perhaps phase-2 should be more sophisticated?

RC2 just crashed with all this fiddling...



-----
OpenSCAD Admin - email* me if you need anything,  or if I've done something stupid...

* on the Forum, click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. Obviously inclusion of works of previous authors is not included in the above.

--
Sent from: http://forum.openscad.org/

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
OpenSCAD Admin - email* me if you need anything, or if I've done something stupid...
* on the Forum, click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain;
to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
> Anyways why do you care if you are using your own external editor?

Because when I pan with the mouse I eventually end up opening a random file that gets rendered wiping out my two minute render that is posed by a dozen customiser settings that are all lost.

When the mouse click is disabled when the editor is hidden it will no longer affect my normal use, but I might want to occasionally unhide the editor to make use of the feature. In that case I could turn off auto reload manually to stop the new tabs being previewed. Perhaps that should be ignored when the tab is opened via the stack trace, as in most cases the file opened does not display anything, so it just clears the original preview. I imagine in most cases you might want to click on another part of the original preview and don't want it erased.

Regardless I think customiser state should be per tab rather than per main window as they are now.

On Wed, 9 Dec 2020 at 02:39, MichaelAtOz <[hidden email]> wrote:
thehans wrote
> On Tue, Dec 8, 2020 at 12:10 PM nop head &lt;

> nop.head@

> &gt; wrote:
>
>> > Perhaps we need an Edit/Preferences/Advanced/UI/Enable-tabs setting?
>>
>> I think the proper solution is to fix all the bugs in the tabs feature.
>>
>> Customiser settings need to be stored per tab.
>>
>> Changing tabs should force a preview consistently. At the moment it seems
>> to be when a new tab is opened but not when switching back to the old
>> tabs.
>>
>
> It sounds like you have "Automatic Reload and Preview" enabled, so it
> previews when a new file/tab is opened.  That's only supposed to reload
> when the file on disk changes, right?  Not really much to do with tabs.

Seems Auto-reload-preview is triggered by just changing tabs, I don't think
it should do so.

Hmmm, that definitely happened, 
I had previously changed code in the first tab,
I can't remember which tab was live when I selected auto-reload-preview,
but when I was on the second tab I clicked back to tab 1,
it asked if I really wanted to reload, I said no.
But I haven't been able to reproduce it...
(and I'm 98.95% sure nothing modified the tab 1 file outside OpenSCAD)

Ahhh, customizer was viewable, with auto-preview selected.
I'm wondering if there is some unintended interaction.

I'll try some more combinations.


> Changing tabs should force a preview consistently. At the moment it seems
> to be when a new tab is opened but not when switching back to the old
> tabs.

See above, it did once on switching back.

When an existing file is opened in a new tab with auto-reload-preview,
preview is appropriate and consistent with past behaviour.

You, ie I, don't really want tabs to preview just switching to them,
I have one with a 30 minute minkowski preview.
If other tabs are libraries, you don't want them previewing.

Perhaps auto-reload-preview setting should be tab specific?
New tabs inherit the setting of the current tab??

ATM tabs are editor entities, not preview/render/customizer instances, ATM.
Perhaps phase-2 should be more sophisticated?

RC2 just crashed with all this fiddling...



-----
OpenSCAD Admin - email* me if you need anything,  or if I've done something stupid...

* on the Forum, click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. Obviously inclusion of works of previous authors is not included in the above.

--
Sent from: http://forum.openscad.org/

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

nophead
Although people claim this is fixed in master I think it is only fixed if you hide the editor.

It is far too easy to trigger and there seems to be something odd with the mouse handling in general. For example, I can centre the view with left double click, right double click and even centre double click. Why?

And when the menu appears after a right click I can then right click on it to jump to the code. I think perhaps my mouse has switch bounce on the right button because Microsoft do not appear to know how to debounce buttons. In normal use I would not notice because right double click is not a thing normally.

I think only ctrl-left click should bring up the menu and only left click should select an item.






On Wed, 9 Dec 2020 at 09:06, nop head <[hidden email]> wrote:
> Anyways why do you care if you are using your own external editor?

Because when I pan with the mouse I eventually end up opening a random file that gets rendered wiping out my two minute render that is posed by a dozen customiser settings that are all lost.

When the mouse click is disabled when the editor is hidden it will no longer affect my normal use, but I might want to occasionally unhide the editor to make use of the feature. In that case I could turn off auto reload manually to stop the new tabs being previewed. Perhaps that should be ignored when the tab is opened via the stack trace, as in most cases the file opened does not display anything, so it just clears the original preview. I imagine in most cases you might want to click on another part of the original preview and don't want it erased.

Regardless I think customiser state should be per tab rather than per main window as they are now.

On Wed, 9 Dec 2020 at 02:39, MichaelAtOz <[hidden email]> wrote:
thehans wrote
> On Tue, Dec 8, 2020 at 12:10 PM nop head &lt;

> nop.head@

> &gt; wrote:
>
>> > Perhaps we need an Edit/Preferences/Advanced/UI/Enable-tabs setting?
>>
>> I think the proper solution is to fix all the bugs in the tabs feature.
>>
>> Customiser settings need to be stored per tab.
>>
>> Changing tabs should force a preview consistently. At the moment it seems
>> to be when a new tab is opened but not when switching back to the old
>> tabs.
>>
>
> It sounds like you have "Automatic Reload and Preview" enabled, so it
> previews when a new file/tab is opened.  That's only supposed to reload
> when the file on disk changes, right?  Not really much to do with tabs.

Seems Auto-reload-preview is triggered by just changing tabs, I don't think
it should do so.

Hmmm, that definitely happened, 
I had previously changed code in the first tab,
I can't remember which tab was live when I selected auto-reload-preview,
but when I was on the second tab I clicked back to tab 1,
it asked if I really wanted to reload, I said no.
But I haven't been able to reproduce it...
(and I'm 98.95% sure nothing modified the tab 1 file outside OpenSCAD)

Ahhh, customizer was viewable, with auto-preview selected.
I'm wondering if there is some unintended interaction.

I'll try some more combinations.


> Changing tabs should force a preview consistently. At the moment it seems
> to be when a new tab is opened but not when switching back to the old
> tabs.

See above, it did once on switching back.

When an existing file is opened in a new tab with auto-reload-preview,
preview is appropriate and consistent with past behaviour.

You, ie I, don't really want tabs to preview just switching to them,
I have one with a 30 minute minkowski preview.
If other tabs are libraries, you don't want them previewing.

Perhaps auto-reload-preview setting should be tab specific?
New tabs inherit the setting of the current tab??

ATM tabs are editor entities, not preview/render/customizer instances, ATM.
Perhaps phase-2 should be more sophisticated?

RC2 just crashed with all this fiddling...



-----
OpenSCAD Admin - email* me if you need anything,  or if I've done something stupid...

* on the Forum, click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. Obviously inclusion of works of previous authors is not included in the above.

--
Sent from: http://forum.openscad.org/

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: What is supposed to trigger the mouse click stack trace?

jotweh
There seems to be something at odds with the key handling in general.

I do confirm that select is triggered on either button press - which I see as a bug and will go to fix asap, should be only on left button, PR incoming.
Also double-right click is strange, but I hope to fix it with the same solution.

Selecting in the list with a right click is a Qt/OS Feature (you have the same Action when you go File->New File (Right click)).

I would like to have more comments, but I am open for Ctrl+Left as select action - But I will move this discussion to IRC.


On 16/12/2020 19.08, nop head wrote:
Although people claim this is fixed in master I think it is only fixed if you hide the editor.

It is far too easy to trigger and there seems to be something odd with the mouse handling in general. For example, I can centre the view with left double click, right double click and even centre double click. Why?

And when the menu appears after a right click I can then right click on it to jump to the code. I think perhaps my mouse has switch bounce on the right button because Microsoft do not appear to know how to debounce buttons. In normal use I would not notice because right double click is not a thing normally.

I think only ctrl-left click should bring up the menu and only left click should select an item.






On Wed, 9 Dec 2020 at 09:06, nop head <[hidden email]> wrote:
> Anyways why do you care if you are using your own external editor?

Because when I pan with the mouse I eventually end up opening a random file that gets rendered wiping out my two minute render that is posed by a dozen customiser settings that are all lost.

When the mouse click is disabled when the editor is hidden it will no longer affect my normal use, but I might want to occasionally unhide the editor to make use of the feature. In that case I could turn off auto reload manually to stop the new tabs being previewed. Perhaps that should be ignored when the tab is opened via the stack trace, as in most cases the file opened does not display anything, so it just clears the original preview. I imagine in most cases you might want to click on another part of the original preview and don't want it erased.

Regardless I think customiser state should be per tab rather than per main window as they are now.

On Wed, 9 Dec 2020 at 02:39, MichaelAtOz <[hidden email]> wrote:
thehans wrote
> On Tue, Dec 8, 2020 at 12:10 PM nop head &lt;

> nop.head@

> &gt; wrote:
>
>> > Perhaps we need an Edit/Preferences/Advanced/UI/Enable-tabs setting?
>>
>> I think the proper solution is to fix all the bugs in the tabs feature.
>>
>> Customiser settings need to be stored per tab.
>>
>> Changing tabs should force a preview consistently. At the moment it seems
>> to be when a new tab is opened but not when switching back to the old
>> tabs.
>>
>
> It sounds like you have "Automatic Reload and Preview" enabled, so it
> previews when a new file/tab is opened.  That's only supposed to reload
> when the file on disk changes, right?  Not really much to do with tabs.

Seems Auto-reload-preview is triggered by just changing tabs, I don't think
it should do so.

Hmmm, that definitely happened, 
I had previously changed code in the first tab,
I can't remember which tab was live when I selected auto-reload-preview,
but when I was on the second tab I clicked back to tab 1,
it asked if I really wanted to reload, I said no.
But I haven't been able to reproduce it...
(and I'm 98.95% sure nothing modified the tab 1 file outside OpenSCAD)

Ahhh, customizer was viewable, with auto-preview selected.
I'm wondering if there is some unintended interaction.

I'll try some more combinations.


> Changing tabs should force a preview consistently. At the moment it seems
> to be when a new tab is opened but not when switching back to the old
> tabs.

See above, it did once on switching back.

When an existing file is opened in a new tab with auto-reload-preview,
preview is appropriate and consistent with past behaviour.

You, ie I, don't really want tabs to preview just switching to them,
I have one with a 30 minute minkowski preview.
If other tabs are libraries, you don't want them previewing.

Perhaps auto-reload-preview setting should be tab specific?
New tabs inherit the setting of the current tab??

ATM tabs are editor entities, not preview/render/customizer instances, ATM.
Perhaps phase-2 should be more sophisticated?

RC2 just crashed with all this fiddling...



-----
OpenSCAD Admin - email* me if you need anything,  or if I've done something stupid...

* on the Forum, click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. Obviously inclusion of works of previous authors is not included in the above.

--
Sent from: http://forum.openscad.org/

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org


_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org