Re: patch to save design setting(s) (Giles Bathgate)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: patch to save design setting(s) (Giles Bathgate)

donbright
Hi Giles

Sorry about that. This patch applies cleanly against the latest git pull.

Thank you.

-DB

save_design_settings.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: patch to save design setting(s) (Giles Bathgate)

Giles Bathgate-2
Don,

The patch you attached is corrupt:

giles@masala:~/openscad$ git apply ../save_design_settings.diff
fatal: corrupt patch at line 9

The correct way to generate patches using git is using

git format-patch <commit>

Where <commit> is the commit hash of the commit you wish to submit a
patch for. It will be called 0001-something.patch . I think what you
have done is put the output of git show, or git log -p into a file?

Regards

Giles

On 5 July 2011 23:13, Don Bright <[hidden email]> wrote:

> Hi Giles
>
> Sorry about that. This patch applies cleanly against the latest git pull.
>
> Thank you.
>
> -DB
>
> _______________________________________________
> OpenSCAD mailing list
> [hidden email]
> http://rocklinux.net/mailman/listinfo/openscad
>
>

Reply | Threaded
Open this post in threaded view
|

Re: patch to save design setting(s) (Giles Bathgate)

donbright
Hi Giles

Sorry about that. I was using a text editor on the patch file and
using 'patch -p1' to apply it.

I will try to submit the patch via github instead, as you recommended.
Thank you

-DB

On Tue, Jul 5, 2011 at 5:28 PM, Giles Bathgate <[hidden email]> wrote:

> Don,
>
> The patch you attached is corrupt:
>
> giles@masala:~/openscad$ git apply ../save_design_settings.diff
> fatal: corrupt patch at line 9
>
> The correct way to generate patches using git is using
>
> git format-patch <commit>
>
> Where <commit> is the commit hash of the commit you wish to submit a
> patch for. It will be called 0001-something.patch . I think what you
> have done is put the output of git show, or git log -p into a file?
>
> Regards
>
> Giles
>
> On 5 July 2011 23:13, Don Bright <[hidden email]> wrote:
>> Hi Giles
>>
>> Sorry about that. This patch applies cleanly against the latest git pull.
>>
>> Thank you.
>>
>> -DB
>>
>> _______________________________________________
>> OpenSCAD mailing list
>> [hidden email]
>> http://rocklinux.net/mailman/listinfo/openscad
>>
>>
> _______________________________________________
> OpenSCAD mailing list
> [hidden email]
> http://rocklinux.net/mailman/listinfo/openscad
>