Re: 2d Minkowski mostly working

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: 2d Minkowski mostly working

kintel
Administrator
Len,

Thanks a lot for he minkowski2 patch - I've pushed it to master.
It would be cool if you/someone could write some examples to exercise this. If it works well, I'd say we keep it.

There will be automated tests for such coming up after the release, so the more the better :)

For all others: this will make minkowski() work also for 2D objects, e.g.

minkowski() {
  square([10,10]);
  circle(2,2);
}

 -Marius


Reply | Threaded
Open this post in threaded view
|

Re: 2d Minkowski mostly working

Len Trigg
On Mon, Apr 11, 2011 at 3:46 AM, Marius Kintel <[hidden email]> wrote:
> Thanks a lot for he minkowski2 patch - I've pushed it to master.
> It would be cool if you/someone could write some examples to exercise this. If it works well, I'd say we keep it.

Yep, will definitely do up a few examples to show the types of objects
it can and can't handle (for example, currently I think it can't deal
with objects containing holes).

> There will be automated tests for such coming up after the release, so the more the better :)

How are you planning on doing these? Are you thinking along the lines
of regression tests, automatically run scripts checking for crashes,
and maybe generate images and compare them to previously generated
images?

> For all others: this will make minkowski() work also for 2D objects, e.g.
>
> minkowski() {
>  square([10,10]);
>  circle(2,2);
> }

We should have a "how many ways can we make a rounded box" demo - with
the new convex hull function you can also do it as the convex hull of
four circles.

I think if we can also get the CGAL subdivision function plugged in it
will really open things up to creating more organic objects than is
currently possible in openscad.

Cheers,
Len.

Reply | Threaded
Open this post in threaded view
|

Re: 2d Minkowski mostly working

kintel
Administrator
On Apr 10, 2011, at 23:35 PM, Len Trigg wrote:
>
> How are you planning on doing these? Are you thinking along the lines
> of regression tests, automatically run scripts checking for crashes,
> and maybe generate images and compare them to previously generated
> images?
>
Yes, yes and yes : )
I'd love to go the image compare route. The small detail missing there is to get a stable, multi-platform offscreen-renderer up and running using OpenCSG. I tinkered with that a while back, but didn't find a really good solution.

The crash test would be interesting to run against e.g. all openscad models on Thingiverse.

Basic regression tests would compare misc. output from components (dump, statistics etc.).

This is partially up and running in the visitor branch.

 -Marius