GSoC OpenSCAD project

classic Classic list List threaded Threaded
49 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
I've just started fiddling with the Customizer feature. Looking good.

Initial view is that it takes up too much screen real-estate, particularly vertically.



Compared to the editor and console the variable description and name are too big.
Given that the name is bolded it doesn't need to be bigger. (red above)
And the surrounding whitespace is too big.

The vertical spacing, blue marks, should be similar in size to the line spacing in the editor. IMO
Is the box around each variable necessary?

Perhaps "Preset:" could be to the left of the drop-down, thus saving that mostly blank line.

Note that the above OpenSCAD window is vertically my whole monitor size, the small amount of Customizer information that fits is not efficient.

Yes, I know you can collapse the tabs.



It'd be better to have a blank description take zero vertical space.



Clicking to the sides of the slider, ie blue area, moves the handle way too much in one step. Perhaps it could be a percentage of the range? Like maybe 15% steps?



The borders of the Customizer pane should align with the rest, blue/red bits.

---

What was the result of the discussion re order of the tabs, order in code v's alphabetical?
I'd +1 for order in code.

That's my first quick look.
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
tp3
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

tp3
Von: MichaelAtOz <[hidden email]>

> Initial view is that it takes up too much screen
> real-estate, particularly vertically.
>
Hmm, seems like the font sizes on Windows are wrong, on
Linux the sizes are "normal" like the other UI elements.

Added to https://github.com/openscad/openscad/issues/1781

> Given that the name is bolded it doesn't need to be
> bigger. (red above) And the surrounding whitespace is
> too big.
>
Also added.

> The vertical spacing, blue marks, should be similar
> in size to the line spacing in the editor. IMO
>
Hmm, not sure about that, the line spacing in editor
can be separately configured, and matching that seems
a bit strange. It should follow the general GUI though.

> Is the box around each variable necessary?
>
I think it's useful, but I guess we can experiment when
trying to make the whole display a bit more compact.

> Perhaps "Preset:" could be to the left of the drop-down,
> thus saving that mostly blank line.
>
That part probably will change a bit anyway. I'm not
yet sure how to best handle the presets and it would
be also useful to add some more info, basically making
the current "preset" file some kind of project file.
(maybe adding some more meta data for the model, like
author, description, license, ...).

> It'd be better to have a blank description take zero
> vertical space.
>
Already listed in the github issue.

> Clicking to the sides of the slider, ie blue area,
> moves the handle way too much in one step. Perhaps
> it could be a percentage of the range? Like maybe
> 15% steps?
>
Yep, some percentage sounds good.

> The borders of the Customizer pane should align with
> the rest, blue/red bits.
>
Also Yep.

> What was the result of the discussion re order of
> the tabs, order in code v's alphabetical?
>
It's listed in the issue already, I think it might
make sense to support both. Most IDE's do that. I
guess depending on the use case one or the other can
be better. When writing the code yourself, the code
order probably makes more sense, for models made by
someone else with lots of parameters the alphabetical
order could be useful.
In case of huge disagreement, I'd prefer the code
order too :-).

ciao,
  Torsten.

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

Amarjeet Kapoor
On 17 October 2016 at 14:42, Torsten Paul <[hidden email]> wrote:
> Von: MichaelAtOz <[hidden email]>
>
>
>> It'd be better to have a blank description take zero
>> vertical space.
>>
> Already listed in the github issue.
>

This is also already done.

>> Clicking to the sides of the slider, ie blue area,
>> moves the handle way too much in one step. Perhaps
>> it could be a percentage of the range? Like maybe
>> 15% steps?
>>
> Yep, some percentage sounds good.
>

Unable to understand

>> The borders of the Customizer pane should align with
>> the rest, blue/red bits.
>>
> Also Yep.
>

Unable to get understand

--
Amarjeet Singh
https://amarjeetkapoor1.wordpress.com
https://github.com/amarjeetkapoor1
https://bitbucket.org/amarjeetkapoor

"The journey of a thousand commit begins with a single init"

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
tp3
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

tp3
Von: "Amarjeet Kapoor" <[hidden email]>
> > > It'd be better to have a blank description
> > > take zero vertical space.
> > >
> > Already listed in the github issue.
> >
> This is also already done.
>
Ahh, nice. Can you have a look at the github issue
and click the checkboxes for things that are already
solved?

IIRC the "Consider rewriting all use of Expressions
in the customizer to simply use Value objects. That
will make it simpler to deal with literals, as all
Value objects are literals."
is also done?

> > > Clicking to the sides of the slider, ie blue area,
> > > moves the handle way too much in one step. Perhaps
> > > it could be a percentage of the range? Like maybe
> > > 15% steps?
> > >
> > Yep, some percentage sounds good.
> >
> Unable to understand
>
Have a look at the slider screenshot in the original
post. If the slider is changed not by clicking the
handle and dragging it, but by single clicking in
the areas circled in blue, the slider pages to the
next value. The PageUp/PageDown keys should do the
same. I think Qt calls this pageStep.

> > > The borders of the Customizer pane should align
> > > with the rest, blue/red bits.
> > >
> > Also Yep.
>  >
> Unable to get understand
>
See the screenshot which highlights the different
window borders (or margins?) in blue (customizer) and
red (other windows). Looks like we currently have much
bigger border configured for the customizer window.

ciao,
  Torsten.

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

Amarjeet Kapoor
On 17 October 2016 at 16:02, Torsten Paul <[hidden email]> wrote:

> Von: "Amarjeet Kapoor" <[hidden email]>
>> > > It'd be better to have a blank description
>> > > take zero vertical space.
>> > >
>> > Already listed in the github issue.
>> >
>> This is also already done.
>>
> Ahh, nice. Can you have a look at the github issue
> and click the checkboxes for things that are already
> solved?
>

I mainly mark the issues which are done. So, mainly no new addition.

> IIRC the "Consider rewriting all use of Expressions
> in the customizer to simply use Value objects. That
> will make it simpler to deal with literals, as all
> Value objects are literals."
> is also done?
>

No.

>
> See the screenshot which highlights the different
> window borders (or margins?) in blue (customizer) and
> red (other windows). Looks like we currently have much
> bigger border configured for the customizer window.
>

Okay, thanks.


--
Amarjeet Singh
https://amarjeetkapoor1.wordpress.com
https://github.com/amarjeetkapoor1
https://bitbucket.org/amarjeetkapoor

"The journey of a thousand commit begins with a single init"

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

Ronaldo
I have explored the Customizer mainly to build demos of libraries. And it does a good job but may be improved. I agree that there is a waste of space in the customizer window. Any more compact design is welcome. The order of the parameter is not reasonable: instead of alphabetical it should be the order of appearance in the program file. The description of a parameter should be the default: only when it is not available the parameter identifier would be used. Usually the identifier is not as descriptive and requires a lot of space. The "Show details" option should be changed accordingly.

The best window arrangement I found for demos is to overlap the customizer, editor and console windows:



This is the image of a demo of my fork of sweep.scad with this window arrangement.

I observed an issue when editing fields like the ref_end parameter in the image, a vector. If you click any of the vector fields to edit it, just after a character is inserted or deleted, a new preview is done and the cursor miraculously move to the beginning of the first field. That is annoying and seems to be a bug. It would be better to require an ENTER to end the editing mode and produce a preview.

I have explored the customizer only in a Windows 7 environment.
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

Ronaldo
In editing a field of a vector, the two arrow icons are useless. When in a field, the up and down keyboard keys are better options for that. Page up and down allowing greater jumps (hundreds), left and right for middle jumps (tenths).

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
In reply to this post by MichaelAtOz
Comparing Thingiverse thing Sheriffs Badge in Thingiverse Customizer (TVC) v's OpenSCAD Customizer (OSC).

[OpenSCAD version 2016.10.05 (git 4b59170) ]

I'm not sure to what degree they are meant to be compatible so I noted anything I found below.

a. TVC Underscores in Variable_name are changed to spaces, looks nicer.



a2. The side by side layout allows creative use of name/description, as above or this use



v's



b. TVC Order of tabs is order in code, allows logical layout.

c. Order of variables in tab is the same, alphabetical. Note I had to name variables starting with numbers to order them. I think it should be the same order as code, and suggest Thingiverse change that way.

d. <oops>

e. TVC stops processing variables at the first non assignment operation, see 'module dummy()' in above Thing, OSC is getting a range of working variables in the tabs which should not be there, also getting variables from module parameters. Can't tell where it got 'pi' from - correction - it got it and other variables from the include <write.scad> ...

(had to stop comparison, TVC is stuffed ATM)

Separate issues:

There is conflict with the scroll wheel between scrolling the customizer pane, and changing slider values (and up/down, drop-down controls). If when scrolling the pane, the mouse happens to rest over a slider the scroll wheel then changes the slider instead of scrolling more. Not sure of best approach to this, as scrolling the controls could be useful, but when testing I had many unintentional changes to control values until I worked out what was going on.
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
tp3
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

tp3
Von: MichaelAtOz <[hidden email]>
> I'm not sure to what degree they are meant to be
> compatible so I noted anything I found below.
>
Thanks for having a look at that. We did not really
declare an official compatibility list, but the basic
idea is to follow the syntax and behavior as close
as possible and reasonable.
For the GUI part things are a bit more relaxed as
we have different options and at least can try to
make it easier for the user.

> a. TVC Underscores in Variable_name are changed
> to spaces, looks nicer.
>
Good point. If we go for "hide variable name if
description is there" it might not be too important,
but I guess there's quite a number of model that
don't have a description.

> a2. The side by side layout allows creative use
> of name/description, as above or this use
>
I think we have to accept those kind of glitches,
maybe filtering descriptions that look strange by
some rule.
Trying to exactly follow the display is a lost
cause in my opinion.

> b. TVC Order of tabs is order in code, allows
> logical layout.
>
Yeah, I guess code order gets most votes by far,
so we probably want that or have a toggle for
both code and alphabetical order.

> d. <oops>
>
???
Missing screenshot maybe?

> e. TVC stops processing variables at the first
> non assignment operation
>
Oh, hmm, we certainly should find a fix for that.
Maybe we want to even move that to the list of
things to fix before merging to the main dev
branch.

ciao,
  Torsten.

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
tp3 wrote
> d. <oops>
>
???
Missing screenshot maybe?
No. <oops>, d. was not an issue after all. It was [Global], until I checked with TVC I felt it should list the globals above tabs showing all the time.
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
Was there any resolution to getting decimal places in a customizer variable?
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

kintel
Administrator

> On Nov 10, 2016, at 18:09, MichaelAtOz <[hidden email]> wrote:
>
> Was there any resolution to getting decimal places in a customizer variable?
>
Added to https://github.com/openscad/openscad/issues/1781

If any of the listed items are significantly more critical than others, feel free to create a new issue so we can prioritize it differently.

 -Marius


_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
Is there a Windows exe with the latest (post 2016.10.05) customizer changes?
I don't want to comment on what may be fixed already...
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
<Thinking Cap>:
Find a way to integrate assert() with customizer GUI.
</Thinking Cap>
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

kintel
Administrator
In reply to this post by MichaelAtOz
On Nov 11, 2016, at 00:15, MichaelAtOz <[hidden email]> wrote:
>
> Is there a Windows exe with the latest (post 2016.10.05) customizer changes?
> I don't want to comment on what may be fixed already…
>
Not yet, but it will be on the way as soon as we get a chance to manually kick off a Windows build..

 -Marius


_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
tp3
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

tp3
On 11/11/2016 03:44 PM, Marius Kintel wrote:
> Not yet, but it will be on the way as soon as we get a chance
> to manually kick off a Windows build..
>
I've build binaries from master (which are totally untested
and available at http://files.openscad.org/snapshots/) but
those are missing compression support for AMF, looks like I
just forgot to update the build script.
As MXE decided to do a full rebuild, it's going to take a
couple of hours before I can follow up on that.

But anyway, please have a look at the Nov 11th binaries,
the latest Customizer updates should be in there.

ciao,
  Torsten.



_______________________________________________
OpenSCAD mailing list
[hidden email]
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
tp3 wrote
But anyway, please have a look at the Nov 11th binaries,
the latest Customizer updates should be in there.
Thanks. Noting not many of above issues resolved - not complaining, just saying.

Amarjeet Kapoor wrote
>> It'd be better to have a blank description take zero
>> vertical space.
>>
> Already listed in the github issue.
>

This is also already done.
Didn't make it to this snapshot?

---------------------------------------------------------
I'll only mention new observations below.

Currently, for slider, I used [min:0.1:max] which makes the single click to the left/right change by 1, from glancing at the code that seems to be by factor of 10 ATM. I'd suggest where a step size is specified, that amount is used as the increment, i.e [min:1:max] would step by 1. Where no step is specified then current behaviour. (??)
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
I needed a new insert for my bandsaw, so designed one.
Decided to customize it.

Feel free to use as example if suitable.

// Released to the Public Domain
// Bandsaw insert plate
// TODO: currently assumes gap is always in the centre.

/* [Size in 1/10 mm] Main Tab */
// Width i.e right angle to blade
X=380; // [1:0.1:500]  // ATM 0.1 makes slider 'click' change by 1
// Depth i.e. parallel to blade
Y=380; // [1:0.1:500]
// Height or thickness
H=21;
// Zero for square corners
Corner_Radius=30;
// Gap not incl. the beveled cut
Gap_X=40; // [1:500]
Gap_Y=288; // [1:0.1:500]

/* [Holes] */
// In 1/10 mm
Hole_Diameter=48; //
// per side
Number_of_Holes=3; // [0:0.1:6]

/* [Options] */
// Bevel the gap for a tilt table
Tilt_Bevel=true;
// Facets in a circle
$fn=16; // [3,4,8,12,16,20,24,28,32]

/* [Hidden] */
// Convert Customizer inputs to working resolution
X_=X/10;
Y_=Y/10;
H_=H/10;
CR=(Corner_Radius== 0
        ? 0.05 // fudge for squar-ish corners
        : Corner_Radius)/10;
gapX=Gap_X/10;
gapY=Gap_Y/10;
holeD=Hole_Diameter/10;
difference() {
        linear_extrude(height=H_,convexity=10)
                difference() {
                        // square with rounded corners
                        hull() {
                                for (  x=[CR,X_-CR]
                                                , y=[CR,Y_-CR])
                                        translate([x,y])
                                                circle(r=CR);
                        } // h
                        // -
                        translate([X_/2-gapX/2,Y_-gapY])
                                square([gapX,gapY+0.05]);
                        for (  i=[0.25,0.75])
                                translate([X_*i,0])
                                        for ( j=[ (Number_of_Holes==0 ? 0:1) : Number_of_Holes])
                                                //echo(i,j);
                                                translate([0,X_/Number_of_Holes*j-X_/Number_of_Holes/2])
                                                        circle(d=holeD);
                } // d
        // -
        // 45 degree bevel - clearance for table tilt
        if (Tilt_Bevel)
                translate([X_/2+gapX/2,Y_-gapY,-0.05])
                        rotate([0,-45,0])
                        cube([gapX*3,gapY+0.05,H_*3]);
} // d
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
This post was updated on .
oops - minor correction - correctly align holes...

edit - original above is correct.
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
Reply | Threaded
Open this post in threaded view
|

Re: GSoC OpenSCAD project

MichaelAtOz
Administrator
well that's embarrassing...wrong again...
Admin - email* me if you need anything,
or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.


The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ time is running out!
123