Dev-Snapshots with the new editor component

classic Classic list List threaded Threaded
20 messages Options
tp3
Reply | Threaded
Open this post in threaded view
|

Dev-Snapshots with the new editor component

tp3
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

stonysmith
I know it's an odd thing, but just to re-iterate.. I downloaded the Aug25 64 bit ZIP form of the Windows executable.
I'm running it by double clicking the exe on a Win7 machine (not using the official installer)

Almost any key except for the alphanumerics does not function in either editor.

None of these keys do anything:
Backspace
Delete
Enter
F1...F12
Tab

I had the same trouble with the earlier snapshot as well.  The stable build works fine for me.
tp3
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

tp3
stonysmith wrote
I had the same trouble with the earlier snapshot as well.  The stable build works fine for me.
Can you provide some more information about that system? It's working fine on the virtual machine I've used for testing the installer and also seems to work for other people.

So maybe it's some interaction with system settings like language or keyboard.
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

MichaelAtOz
Administrator
Latest version also works fine here. Win7/64, exe from zip file. I have USB Wireless keyboard.
Admin - email* me if you need anything, or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

kintel
Administrator
In reply to this post by stonysmith

On Aug 27, 2014, at 16:09 PM, stonysmith <[hidden email]> wrote:

> Almost any key except for the alphanumerics does not function in either
> editor.
> […]
> I had the same trouble with the earlier snapshot as well.  The stable build
> works fine for me.
>
Does the latest non-scintilla build work for you?
http://files.openscad.org/snapshots/OpenSCAD-2014.07.22-x86-64.zip

 -Marius

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://rocklinux.net/mailman/listinfo/openscad
http://openscad.org - https://flattr.com/thing/121566
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

stonysmith
Yes, that version works just fine.
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

stonysmith
Just to provide some background..

Dell N5110 Notebook
Intel i5-2340M CPU @2.4ghz
Intel HD Graphics 3000
4gb ram
500gb disk with 355gb free space
Win7/64 bit with latest patches

Using hard keyboard with no virtualization at all.

I've been an OpenSCAD user since at least Jan of 2010
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

kintel
Administrator
In reply to this post by stonysmith
On Aug 28, 2014, at 22:42 PM, stonysmith <[hidden email]> wrote:

> Yes, that version works just fine.
>
Thanks for the feedback - we’ll build s new version soon, without the Scintilla component, so we can get to the bottom of this.

 -Marius

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://rocklinux.net/mailman/listinfo/openscad
http://openscad.org - https://flattr.com/thing/121566
tp3
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

tp3
Hmm, my best idea right now is to build two versions based on the code in master (without scintilla editor). One using the previously used MXE-stable / 64 bit and one with the MXE-master branch which we need for scintilla.

As this happens with the 64 bit build, it's not the switch to mingw-w64 as this is only the case for the 32 bit build. The 64 bit build did use that before... still very strange.
-- Torsten
tp3
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

tp3
In reply to this post by stonysmith
@stonysmith, can you please check the following two builds:

Code from OpenSCAD master / build with MXE stable (target = x86_64-w64-mingw32):
http://files.openscad.org/snapshots/OpenSCAD-2014.08.30-x86-64.zip
http://files.openscad.org/snapshots/OpenSCAD-2014.08.30-x86-64-Installer.exe

Exact same OpenSCAD code / build against MXE master branch (target = x86_64-w64-mingw32.static)
http://files.openscad.org/snapshots/OpenSCAD-2014.08.30-x86-64-mxe-master.zip
http://files.openscad.org/snapshots/OpenSCAD-2014.08.30-x86-64-mxe-master-Installer.exe

There should not be any difference between using ZIP or Installer.

Both work on the Win7/64bit VM I'm using for testing.
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

MichaelAtOz
Administrator
Both function for me.
Admin - email* me if you need anything, or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

stonysmith
In reply to this post by tp3
Sorry.. long day with the new grandson.
Both of those (ZIP) versions work fine for me.
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

laird
In reply to this post by tp3
Using the Mac version - it's generally working great - the new editor is pleasant, with line numbers and hilighting and structure compression (e.g. hiding a module's contents). It makes large OpenSCAD code much easier to deal with.

Not the editor, but this build's performance compiling and exporting STLs is fantastic. And the earlier bugs with views not rotating with mouse movement are fixed. Yay!

Some quibbles with the editor:
- The tabs are 8 characters, and 4 would be nice. Others have mentioned that.
- I've twice had the file that I have opened decide that it's "unnamed" so when I save it I have to type in the name again, and agree to replace the existing copy. Not sure that's related to the editor, since I saw this one or two times previously, but it happened more often in this build.
- Syntax errors don't scroll to be visible in the window. They're hilited, but can be off screen; the editor should scroll to the line of the syntax error.
- I always set up the source and the console stacked vertically. Is there a way to save this as default? This is really an MDI issue, not editor, I suppose, but...
- In this arrangement, the 'drag bar' between the two windows is one pixel tall, making it difficult to resize. Could this be expanded to at least 3 pixels tall to make it easier to hit?
- I had one crash. Don't know what caused it, as it managed to not trigger the crash reporter. :-)
- It would be nice to have some style options. For example, I like to write code indented like this:

module foo() {
   stuff
   }

while the editor likes to do this:

module foo() {
   stuff
}

If there were preferences for setting the indenting rules for the editor, that'd be nice. Otherwise I spend time reformatting the editor's auto-indenting to match the rest of my code.
- And as long as the editor is automating some indenting, it'd be nice to trigger the editor to "pretty print" the whole file, so that it's all consistent. :-)
- QScintilla does all sorts of advanced stuff: auto-completion and "tips" and lexing such. Are those wired up? If so, how do I trigger them? If not, is that planned? Is that something I can help with? (Given that I know C, Python and OpenSCAD, but not QT or Scintilla...)
tp3
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

tp3
The QScintilla topic is split into two parts 1) integration / build process / functionality working and 2) make ready for release.

Part 1 is mainly done and will result in the new editor merged to master so it also ends up in the "normal" snapshot builds

Part 2 will cover configuration options and all the needed cleanup -> https://github.com/openscad/openscad/issues/915

laird wrote
- I always set up the source and the console stacked vertically. Is there a way to save this as default? This is really an MDI issue, not editor, I suppose, but...
- In this arrangement, the 'drag bar' between the two windows is one pixel tall, making it difficult to resize. Could this be expanded to at least 3 pixels tall to make it easier to hit?
Can you give some more details for that? Is that with undocked windows or just rearranged inside the main window? At least the last case works fine for me (on Linux). How do you quit the application? I think the window arrangement is only saved when closing the main window.
Maybe that's MacOS specific, as also the drag bar seems to be like 3-4 pixels on Linux.

laird wrote
- It would be nice to have some style options. For example, I like to write code indented like this:

module foo() {
   stuff
   }

while the editor likes to do this:

module foo() {
   stuff
}
I don't think that will happen soon, all the auto-indent behavior is coming from the Scintilla implementation and there seem to be not much options to configure that.

laird wrote
- QScintilla does all sorts of advanced stuff: auto-completion and "tips" and lexing such. Are those wired up? If so, how do I trigger them? If not, is that planned? Is that something I can help with? (Given that I know C, Python and OpenSCAD, but not QT or Scintilla...)
Unfortunately it's not that easy. It provides the framework and some core features, but especially the included calltips provider is a bit useless. The good thing is, it's not too hard to add that in a way which fits OpenSCAD needs a bit better.

See https://github.com/openscad/openscad/pull/905 for some prototype stuff.

Any help would be great, the prototype has all the info in code. Of cause the plan is to put that into external files. But one interesting topic to solve is to decide which information to show in the calltips and maybe create a list of useful templates (where templates are currently formatted code snippets + a cursor offset to put the cursor into the first place where the template needs to be customized).
-- Torsten
tp3
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

tp3
In reply to this post by stonysmith
stonysmith wrote
Sorry.. long day with the new grandson.
Both of those (ZIP) versions work fine for me.
Thanks for testing, so it looks like it's not caused by the new build target. That's good.

But that means it might be caused by some strange interaction with the QScintilla component :(.
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

laird
In reply to this post by tp3
Wow, that prototype is pretty thorough. I'm amazed at how much code you had to write to wire up the standard OpenSCAD functions. Some editors do nifty tricks like parsing your files, and includes, so they can auto-complete on your module names, etc. But I hate to think how much code that would take. Even auto-complete of the built-ins would be a big time saver.

On the PC (Win 8.1 64 bit) there's a gap between the panes in MDI, so resizing is easy. And the configuration appears to be saved between runs.

On the Mac (Mac OS X 10.9.4) the two windows' edges align, so there's just a one pixel tall line that's the edge of both panes, which you  have to hit to resize. It's with two docked windows, stacked vertically.

Also, the window configuration doesn't get saved between runs, so it's defaulting to hiding the console every time, so I have to un-hide it, then drag it to the bottom of the editor window, then resize it, every time.
tp3
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

tp3
In reply to this post by tp3
tp3 wrote
stonysmith wrote
Sorry.. long day with the new grandson.
Both of those (ZIP) versions work fine for me.
Thanks for testing, so it looks like it's not caused by the new build target. That's good.

But that means it might be caused by some strange interaction with the QScintilla component :(.
Stonysmith, can you please check the new snapshot:
http://files.openscad.org/snapshots/OpenSCAD-2014.09.05-x86-64-Installer.exe
http://files.openscad.org/snapshots/OpenSCAD-2014.09.05-x86-64.zip

Those are the "normal" snapshots linked on the OpenSCAD download page. As the new editor is now included, there's a chance the problem is back (the issues is tracked in https://github.com/openscad/openscad/issues/930).
-- Torsten
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

stonysmith
That version openscad-2014.09.05 seems to be working well.

Very odd: when I FIRST opened the program and loaded an existing file, the Home and End keys would do nothing.  But, then I typed a single alphabetic key, and from that point on, everything works. I can't reproduce the problem.
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

MichaelAtOz
Administrator
Give the
QsciCommandSet::readSettings(QSettings &qs, const char *prefix)
perhaps users, such as I, who have used a scintilla based editor (Notepad++ & SciEd) have existing settings which are read. Those who don't, have issues? ????
Admin - email* me if you need anything, or if I've done something stupid...
* click on my MichaelAtOz label, there is a link to email me.

Unless specifically shown otherwise above, my contribution is in the Public Domain; to the extent possible under law, I have waived all copyright and related or neighbouring rights to this work.
Obviously inclusion of works of previous authors is not included in the above.
Reply | Threaded
Open this post in threaded view
|

Re: Dev-Snapshots with the new editor component

kintel
Administrator
On Sep 5, 2014, at 10:16 AM, MichaelAtOz <[hidden email]> wrote:

> Give the
> QsciCommandSet::readSettings(QSettings &qs, const char *prefix)
> perhaps users, such as I, who have used a scintilla based editor (Notepad++
> & SciEd) have existing settings which are read. Those who don't, have
> issues? ????
>
I don’t think so - those are Qt-specific settings and I don’t think Notepad++ or SciEd uses Qt.

 -Marius

_______________________________________________
OpenSCAD mailing list
[hidden email]
http://rocklinux.net/mailman/listinfo/openscad
http://openscad.org - https://flattr.com/thing/121566